Minor networking / serialization changes for better latency on single calls #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkountis
force-pushed
the
perf/minor_enhancments_for_latency
branch
from
cb9e322 to
9c3e734
Compare
tkountis
commented
Jul 3, 2019
mdumandag
reviewed
Jul 3, 2019
tkountis
force-pushed
the
perf/minor_enhancments_for_latency
branch
from
9c3e734 to
223043b
Compare
mdumandag
reviewed
Jul 4, 2019
| self.a_float = inp.read_float() | ||
| self.a_double = inp.read_double() | ||
|
|
||
| self.bytes_ = inp.read_byte_array() |
Contributor
There was a problem hiding this comment.
minor comment: these test changes should not be required anymore and maybe you can add an extra field to test the behaviour when the return value is bytearray
mdumandag
approved these changes
Jul 4, 2019
tkountis
force-pushed
the
perf/minor_enhancments_for_latency
branch
from
223043b to
b07b94c
Compare
mdumandag
approved these changes
Jul 4, 2019
hazelcast/config.py
Outdated
|
|
||
| SERIALIZATION_INPUT_RETURNS_BYTEARRAY = ClientProperty("hazelcast.serialization.input.returns.bytearray", False) | ||
| """ | ||
| Input#read_byte_array returns a List if property is True, otherwise it will return a byte-array. |
Contributor
There was a problem hiding this comment.
List if property is True -> List if property is False
Changing this to False -> Changing this to True
tkountis
force-pushed
the
perf/minor_enhancments_for_latency
branch
from
b07b94c to
f324c61
Compare
asimarslan
approved these changes
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bytearraywhich is slightly concerning because it changes the type of the function, but it gives a good bit of extra boost.