Skip to content

Conversation

@mdumandag
Copy link
Contributor

This PR contains the code samples, documentation and implementation for the distributed object listener and get_distributed_objects method of the client.

Just like the Java client, call to the get_distributed_objects method clears the local instances of the destoyed proxies.

@mdumandag mdumandag requested a review from sancar March 12, 2020 14:18
@fikisipi
Copy link

Maybe support for async get_distributed_objects() makes sense - but I like it.

@mdumandag
Copy link
Contributor Author

Hi @filipArena , considering all the other blocking APIs on the HazelcastClient (get_map, get_list etc.), what is the use case of the async version of this API in your mind ? Maybe we can add get_distributed_objects_async or do something else.

If you ask me, I am not really sure about the async version because I think it will look awkward since there is no async counterpart of the get_data_structure methods. We maybe consider adding those (or making them async by default for the upcoming 4.0 release in which we can do breaking changes).

@asimarslan What do you think ?

@mdumandag
Copy link
Contributor Author

@filipArena We discussed the possibility of the async API in the team and decided to continue with the sync version for now. But feel free to create an issue about it. We may consider it (along with the other changes I mentioned above) for the 4.0 release.

@mdumandag mdumandag merged commit 5ac7bcc into hazelcast:master Mar 13, 2020
@mdumandag mdumandag deleted the dist-obj-listener branch March 13, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants