Support for Paging Predicate implementation #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
|
asimarslan
changed the title
Closed
Contributor
|
verify |
mdumandag
reviewed
Aug 11, 2020
Contributor
mdumandag
left a comment
mdumandag
left a comment
There was a problem hiding this comment.
@yagmurdulger Thanks for the great effort. This PR looks good.
I finished my first round of review and left some comments. Could you take a look at them?
Contributor
Author
|
@mdumandag Thank you very much for the review! I have changed the PR based on your comments and marked them as resolved. There are still a few questions remaining, could you take a look at them? |
Contributor
Author
|
@mdumandag Thanks for your feedback! PR is ready for another round of review. |
Contributor
|
Thanks for the changes @yagmurdulger. I will go over it again |
mdumandag
reviewed
Aug 26, 2020
Contributor
mdumandag
left a comment
mdumandag
left a comment
There was a problem hiding this comment.
@yagmurdulger sorry for the late response, I went over the PR again. It looks pretty good now. I have some further comments and questions.
Contributor
|
verify |
Contributor
Author
|
Hi @mdumandag . Thanks a lot for the second round of review! I have improved the PR based on your suggestions. |
Contributor
|
verify |
mdumandag
approved these changes
Sep 1, 2020
asimarslan
approved these changes
Sep 1, 2020
Merged
Contributor
|
Can one of the admins verify this patch? |
1 similar comment
Contributor
|
Can one of the admins verify this patch? |
mdumandag
added a commit
to mdumandag/hazelcast-python-client
that referenced
this pull request
Oct 16, 2020
This is the port of hazelcast#212 to the 4.0 branch. However, there are some differences from that PR. - Documentation of the feature is a little bit different since the client side sorting is removed. - Tests are more-or-less ported directly with a few additions for input validations. However, the above PR was using `six.assertCounEqual` for assertions which checks equality but not order. For paging predicate tests, it makes more sense to check ordering. - Client side codecs and holder classes for PagingPredicates and AnchorDataLists are added. - Some public methods, like `get_anchor`, `set_anchor`, `get_nearest_anchor_entry` is removed. `get_anchor` is defined on the public API on the Java side but I think it does not provide any functionality to the user.
mdumandag
added a commit
to mdumandag/hazelcast-python-client
that referenced
this pull request
Oct 16, 2020
This is the port of hazelcast#212 to the 4.0 branch. However, there are some differences from that PR. - Documentation of the feature is a little bit different since the client side sorting is removed. - Tests are more-or-less ported directly with a few additions for input validations. However, the above PR was using `six.assertCounEqual` for assertions which checks equality but not order. For paging predicate tests, it makes more sense to check ordering. - Client side codecs and holder classes for PagingPredicates and AnchorDataLists are added. - Some public methods, like `get_anchor`, `set_anchor`, `get_nearest_anchor_entry` is removed. `get_anchor` is defined on the public API on the Java side but I think it does not provide any functionality to the user.
mdumandag
added a commit
to mdumandag/hazelcast-python-client
that referenced
this pull request
Nov 6, 2020
This is the port of hazelcast#212 to the 4.0 branch. However, there are some differences from that PR. - Documentation of the feature is a little bit different since the client side sorting is removed. - Tests are more-or-less ported directly with a few additions for input validations. However, the above PR was using `six.assertCounEqual` for assertions which checks equality but not order. For paging predicate tests, it makes more sense to check ordering. - Client side codecs and holder classes for PagingPredicates and AnchorDataLists are added. - Some public methods, like `get_anchor`, `set_anchor`, `get_nearest_anchor_entry` is removed. `get_anchor` is defined on the public API on the Java side but I think it does not provide any functionality to the user.
mdumandag
added a commit
that referenced
this pull request
Nov 6, 2020
* Implement PagingPredicate This is the port of #212 to the 4.0 branch. However, there are some differences from that PR. - Documentation of the feature is a little bit different since the client side sorting is removed. - Tests are more-or-less ported directly with a few additions for input validations. However, the above PR was using `six.assertCounEqual` for assertions which checks equality but not order. For paging predicate tests, it makes more sense to check ordering. - Client side codecs and holder classes for PagingPredicates and AnchorDataLists are added. - Some public methods, like `get_anchor`, `set_anchor`, `get_nearest_anchor_entry` is removed. `get_anchor` is defined on the public API on the Java side but I think it does not provide any functionality to the user. * address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Paging Predicate. Fixes issue #202