Implement PagingPredicate #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdumandag
force-pushed
the
paging-predicate
branch
from
5437782 to
ffe6405
Compare
This is the port of hazelcast#212 to the 4.0 branch. However, there are some differences from that PR. - Documentation of the feature is a little bit different since the client side sorting is removed. - Tests are more-or-less ported directly with a few additions for input validations. However, the above PR was using `six.assertCounEqual` for assertions which checks equality but not order. For paging predicate tests, it makes more sense to check ordering. - Client side codecs and holder classes for PagingPredicates and AnchorDataLists are added. - Some public methods, like `get_anchor`, `set_anchor`, `get_nearest_anchor_entry` is removed. `get_anchor` is defined on the public API on the Java side but I think it does not provide any functionality to the user.
mdumandag
force-pushed
the
paging-predicate
branch
from
ffe6405 to
5e555ae
Compare
Contributor
Author
|
@puzpuzpuz , I agree with the comments you have made. I copy-pasted almost all of them from the Java reference manual, I will also send a pull request there. |
Contributor
Author
|
Thanks for the quick review |
mdumandag
added a commit
to mdumandag/hazelcast-reference-manual
that referenced
this pull request
Nov 6, 2020
There were some problems in that chapter. Namely, - Explanation of the code sample was not clear. For example, ``values`` should refer to the method call, but it was used in plural form, probably refering the returned collection. - If the comparator is not set, keys or values of the collection should be comparable, not the collection itself. - The note about the transactional context is not related to the paragraphs above. It makes sense to convert it into a note. Credit goes to Andrey for spotting these problems on hazelcast/hazelcast-python-client#232
mdumandag
added a commit
to mdumandag/hazelcast-reference-manual
that referenced
this pull request
Nov 6, 2020
There were some problems with that chapter. Namely, - Explanation of the code sample was not clear. For example, ``values`` should refer to the method call, but it was used in plural form, probably referring to the returned collection. - If the comparator is not set, keys or values of the collection should be comparable, not the collection itself. - The note about the transactional context is not related to the paragraphs above. It makes sense to convert it into a note. Credit goes to Andrey for spotting these problems on hazelcast/hazelcast-python-client#232
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the port of #212
to the 4.0 branch. However, there are some differences from that PR.
side sorting is removed.
input validations. However, the above PR was using
six.assertCounEqualfor assertions which checks equality but not order. For paging predicate
tests, it makes more sense to check ordering.
are added.
get_anchor,set_anchor,get_nearest_anchor_entryis removed.
get_anchoris defined on the public API on the Java side but I thinkit does not provide any functionality to the user.
Also, some missing
six.moves.rangeimports are added.Protocol PR: hazelcast/hazelcast-client-protocol#355