CP Subsystem - CountDownLatch #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
verify |
mdumandag
force-pushed
the
cp-countdown-latch
branch
from
8217049 to
ef87776
Compare
Adds the implementation, documentation, code samples and test of CP CountDownLatch. Also, invocation service is editted to return `OperationTimeoutError` instead of `HazelcastTimeoutError` in case of invocation timeouts as the Java client does.
mdumandag
force-pushed
the
cp-countdown-latch
branch
from
ef87776 to
a0b4e77
Compare
puzpuzpuz
approved these changes
Oct 27, 2020
| self.assertTrue(latch.try_set_count(3)) | ||
| self.assertEqual(3, latch.get_count()) | ||
|
|
||
| def test_try_set_count_when_count_is_already_set(self): |
There was a problem hiding this comment.
nit: does it make sense include a test that verifies that try_set_count succeeds once the count goes to zero?
Contributor
Author
There was a problem hiding this comment.
Good idea. I added the extra test case.
goes back to zero.
Contributor
Author
|
Thanks for the review Andrey, I am merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the implementation, documentation, code samples, and test of
CP CountDownLatch.
Also, the invocation service is edited to return
OperationTimeoutErrorinstead of
HazelcastTimeoutErrorin case of invocation timeoutsas the Java client does.
depends on #224