Fix class definition registrations with the same class id #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdumandag
force-pushed
the
class-def-fix
branch
from
2807d2d to
a69ccc7
Compare
mdumandag
force-pushed
the
class-def-fix
branch
from
a69ccc7 to
3960956
Compare
When class definitions for two different classes with the same class id but different factory ids are registered, we were throwing an error indicating that there are duplicate registrations. However, we should allow such cases. Apart from the fix for that, the PR also includes a test case for null portable serialization. Closes hazelcast#199
mdumandag
force-pushed
the
class-def-fix
branch
from
3960956 to
cc23f6e
Compare
puzpuzpuz
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When class definitions for two different classes with the same class id
but different factory ids are registered, we were throwing an error
indicating that there are duplicate registrations. However, we should
allow such cases.
Apart from the fix for that, the PR also includes a test case for
null portable serialization.
Closes #199