Serialization service improvements #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For integers, unless the user configures the default int type, it will be 4 bytes integer. Therefore, we first check the default setting while looking for serailizer for integer types.
It is not necessary to create a new buffer on `to_byte_array` method before returning. `buffer[:pos]` already creates a copy.
There were checks that assume Data's buffer might be None but this is not possible. Data might have a buffer of length 0, but it can never be None. This commit removes such checks.
We initialize the buffer at the constructor and never set it to None on any of the code paths. Therefore, None checks are not necessary.
mdumandag
force-pushed
the
serialization-service-improvments
branch
from
d34f62f to
61a0f8f
Compare
There is no need to check for int type id on each lookup_default_serializer call. However, this is required for VAR size option.
Contributor
Author
|
Thanks for the review Andrey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commit messages for the explanation.