Do not allow using duplicate field names in ClassDefinitionBuilder [API-391] #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, `add_xxx_field` methods of the ClassDefinitionBuilder checks the class name first, and if it already registered, raises HazelcastSerializationError. Also, missing docstrings for the `add_xxx_field` methods are added.
sancar
reviewed
Apr 5, 2021
| """ | ||
| return self.add_string_array_field(field_name) | ||
|
|
||
| def add_field_def(self, field_def): |
Contributor
There was a problem hiding this comment.
I think this is public by accident as it is in java. Can we add documentation to tell the users that this is private(I am assuming we can not delete it anymore)
Can we add a documentation about the order that fields added should be consistent across all languages and also it should be consistent with write order in writePortable on ClassDefinitionBuilder ?
Contributor
Author
There was a problem hiding this comment.
Added a warning to this method and a note about the field order in the ClassDefinitionBuilder docstring
sancar
approved these changes
Apr 6, 2021
degerhz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change,
add_xxx_fieldmethods of the ClassDefinitionBuilderchecks the class name first, and if it already registered, raises
HazelcastSerializationError.
Also, missing docstrings for the
add_xxx_fieldmethods are added.Closes #330