Skip to content

Removed compact read_XXX_default methods [API-1324] [API-1313] #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuce merged 21 commits into from
Apr 26, 2022
Merged

Removed compact read_XXX_default methods [API-1324] [API-1313] #550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
32c924a
Initial compact config rework
yuce Apr 18, 2022
4f11e5f
Updated docs and code samples
yuce Apr 19, 2022
92e8f00
Black updates
yuce Apr 19, 2022
ae2532d
Addressed review comments
yuce Apr 25, 2022
8f465aa
Addressed review comments
yuce Apr 25, 2022
6f6d8fd
Addressed review comments
yuce Apr 25, 2022
6b4d5fc
Trivial
yuce Apr 25, 2022
df32f6d
Addressed review comments
yuce Apr 25, 2022
3d87465
Removed read_XXX_or_default methods from CompactReader, added get_fie…
yuce Apr 26, 2022
2f12237
Restored FieldKind and move NOT_AVAILABLE to the end.
yuce Apr 26, 2022
e991dc6
Merge branch 'master' into remove-compact-default
yuce Apr 26, 2022
9051585
Fixed test
yuce Apr 26, 2022
d077f1e
Fixed test
yuce Apr 26, 2022
4bb8e77
Fixed test
yuce Apr 26, 2022
e4dd40a
Fixed map event listener predicate update
yuce Apr 26, 2022
d28fb53
Trivial
yuce Apr 26, 2022
47c4c62
Addressed review comments
yuce Apr 26, 2022
0243e0c
Addressed review comments
yuce Apr 26, 2022
ea102c8
Black
yuce Apr 26, 2022
49fed9d
Addressed review comments
yuce Apr 26, 2022
75f7e86
Black
yuce Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions hazelcast/proxy/map.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ def add_entry_listener(
LOADED=loaded_func,
)

if key is not None and predicate:
if key is not None and predicate is not None:
try:
key_data = self._to_data(key)
predicate_data = self._to_data(predicate)
Expand Down Expand Up @@ -215,7 +215,7 @@ def add_entry_listener(
)
response_decoder = with_key_and_predicate_codec.decode_response
event_message_handler = with_key_and_predicate_codec.handle
elif key is not None and not predicate:
elif key is not None and predicate is None:
try:
key_data = self._to_data(key)
except SchemaNotReplicatedError as e:
Expand All @@ -242,7 +242,7 @@ def add_entry_listener(
)
response_decoder = with_key_codec.decode_response
event_message_handler = with_key_codec.handle
elif key is None and predicate:
elif key is None and predicate is not None:
try:
predicate = self._to_data(predicate)
except SchemaNotReplicatedError as e:
Expand Down
6 changes: 3 additions & 3 deletions hazelcast/proxy/replicated_map.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def add_entry_listener(
Returns:
A registration id which is used as a key to remove the listener.
"""
if key is not None and predicate:
if key is not None and predicate is not None:
try:
key_data = self._to_data(key)
predicate_data = self._to_data(predicate)
Expand All @@ -103,7 +103,7 @@ def add_entry_listener(
)
response_decoder = with_key_and_predicate_codec.decode_response
event_message_handler = with_key_and_predicate_codec.handle
elif key is not None and not predicate:
elif key is not None and predicate is None:
try:
key_data = self._to_data(key)
except SchemaNotReplicatedError as e:
Expand All @@ -123,7 +123,7 @@ def add_entry_listener(
request = with_key_codec.encode_request(self.name, key_data, self._is_smart)
response_decoder = with_key_codec.decode_response
event_message_handler = with_key_codec.handle
elif key is None and predicate:
elif key is None and predicate is not None:
try:
predicate = self._to_data(predicate)
except SchemaNotReplicatedError as e:
Expand Down
Loading