-
Notifications
You must be signed in to change notification settings - Fork 73
Centralise Python version specification in GitHub Actions #719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JackPGreen
merged 12 commits into
hazelcast:master
from
JackPGreen:refactor-python-versions-declaration
Feb 18, 2025
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2766f15
Centralise Python version specification
JackPGreen 751b132
Fix
JackPGreen 0744f21
Fix
JackPGreen 2dd4179
Fix
JackPGreen cec7758
Fix
JackPGreen 4618b62
Fix
JackPGreen 9aedf12
Revert
JackPGreen e79e6d7
Test
JackPGreen 250cd87
Revert
JackPGreen 1d03fb3
Merge branch 'master' into refactor-python-versions-declaration
JackPGreen 891c761
Update get-python-versions.yml
JackPGreen 7d2d32c
Formatting
JackPGreen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| name: Get Python versions | ||
|
|
||
| on: | ||
| workflow_call: | ||
| outputs: | ||
| python-versions: | ||
| value: ${{ jobs.get-python-versions.outputs.python-versions }} | ||
| earliest-python-version: | ||
| value: ${{ jobs.get-python-versions.outputs.earliest-python-version }} | ||
| latest-python-version: | ||
| value: ${{ jobs.get-python-versions.outputs.latest-python-version }} | ||
|
|
||
| jobs: | ||
| get-python-versions: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| python-versions: ${{ steps.extract-versions.outputs.python-versions }} | ||
| earliest-python-version: ${{ steps.extract-versions.outputs.earliest-python-version }} | ||
| latest-python-version: ${{ steps.extract-versions.outputs.latest-python-version }} | ||
| steps: | ||
| - id: extract-versions | ||
| run: | | ||
| python_versions='[ "3.8", "3.9", "3.10", "3.11", "3.12" ]' | ||
|
|
||
| echo "python-versions=${python_versions}" >> $GITHUB_OUTPUT | ||
| echo "earliest-python-version=$(echo "${python_versions}" | jq --raw-output '.[0]')" >> $GITHUB_OUTPUT | ||
| echo "latest-python-version=$(echo "${python_versions}" | jq --raw-output '.[-1]')" >> $GITHUB_OUTPUT | ||
| - run: exit 0 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add
3.13there?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve no idea adding 3.13 - but could I raise a follow up PR to do that separately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.