Centralise Python version specification in GitHub Actions #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackPGreen
changed the title
yuce
requested changes
Feb 18, 2025
| steps: | ||
| - id: extract-versions | ||
| run: | | ||
| python_versions='[ "3.8", "3.9", "3.10", "3.11", "3.12" ]' |
Contributor
There was a problem hiding this comment.
Could you also add 3.13 there?
Contributor
Author
There was a problem hiding this comment.
I’ve no idea adding 3.13 - but could I raise a follow up PR to do that separately?
yuce
approved these changes
Feb 18, 2025
JackPGreen
added a commit
that referenced
this pull request
Feb 18, 2025
Addresses #719 (review) Will also require updating branch protection rules.
JackPGreen
added a commit
to JackPGreen/hazelcast-python-client
that referenced
this pull request
Feb 18, 2025
Addresses hazelcast#719 (review). Will also require updating branch protection rules.
JackPGreen
added a commit
that referenced
this pull request
Feb 18, 2025
Addresses #719 (review). Will also require updating branch protection rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We duplicate the specification of Python versions in each of the actions - instead we can centralise it to a single file that all actions can use.
Examples showing the version resolution (not necessarily the actions themselves!) working correctly:
Additional changes: