Skip to content

[TRIVIAL] Skip test_ensure_on_messsage_is_not_none test for older clients#810

Merged
yuce merged 1 commit intohazelcast:masterfrom
yuce:skip-test_ensure_on_message_is_not_none-test
May 7, 2026
Merged

[TRIVIAL] Skip test_ensure_on_messsage_is_not_none test for older clients#810
yuce merged 1 commit intohazelcast:masterfrom
yuce:skip-test_ensure_on_message_is_not_none-test

Conversation

@yuce
Copy link
Copy Markdown
Contributor

@yuce yuce commented May 7, 2026

Recently we added a check for the on_message parameter in the Topic.add_listener message.
Since that check doesn't exist in the released versions of the client, the corresponding test fails for them in the Client compatibility test suite:
https://github.com/hazelcast/client-compatibility-suites/actions/runs/25483639833/job/74776163020

This PR updates the test to skip it for older versions of the client.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.42%. Comparing base (7f69a2d) to head (a0f7aea).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #810   +/-   ##
=======================================
  Coverage   94.41%   94.42%           
=======================================
  Files         401      401           
  Lines       26125    26125           
=======================================
+ Hits        24666    24668    +2     
+ Misses       1459     1457    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yuce yuce changed the title Skip test_ensure_on_messsage_is_not_none test for older clients [TRIVIAL] Skip test_ensure_on_messsage_is_not_none test for older clients May 7, 2026
@yuce yuce requested a review from th0masb May 7, 2026 09:20
@yuce yuce merged commit b0dbc4c into hazelcast:master May 7, 2026
11 checks passed
@yuce yuce deleted the skip-test_ensure_on_message_is_not_none-test branch May 7, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants