Skip to content

Conversation

@lexiv0re
Copy link
Collaborator

@lexiv0re lexiv0re commented Oct 2, 2025

  • Removes unnecessary check on closing enum editing dialog when nothing has changes
  • Adds search capability to DropdownLabelsPopupIntl, also fixes the keyboard selection logic

Before:
IntlDropdownBefore

After:
IntlDropdownAfter

Related to: https://front.hc.engineering/workbench/platform/tracker/UBERF-13844, https://front.hc.engineering/workbench/platform/tracker/UBERF-13845

Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
@huly-github-staging
Copy link

Connected to Huly®: UBERF-13849

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements UI improvements for card type editing by adding search functionality to dropdown lists and removing unnecessary confirmation dialogs. The changes enhance user experience by making dropdown selection more efficient and streamlining the enum editing workflow.

  • Adds search capability to the DropdownLabelsPopupIntl component with keyboard navigation improvements
  • Removes unnecessary confirmation dialog when closing enum editing without changes
  • Enables search functionality in the RefEditor dropdown for class selection

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
packages/ui/src/components/DropdownLabelsPopupIntl.svelte Adds search input, filtering logic, and improved keyboard navigation
packages/ui/src/components/DropdownLabelsIntl.svelte Passes withSearch prop to the popup component
plugins/setting-resources/src/components/typeEditors/RefEditor.svelte Enables search functionality for class selection dropdown
plugins/setting-resources/src/components/EditEnum.svelte Adds logic to skip confirmation dialog when enum values are unchanged

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

BykhovDenis
BykhovDenis previously approved these changes Oct 2, 2025
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
@lexiv0re lexiv0re merged commit edc2378 into develop Oct 2, 2025
15 checks passed
@lexiv0re lexiv0re deleted the uberf-13843/protocols-ui-1 branch October 2, 2025 19:03
Copy link
Member

@ArtyomSavchenko ArtyomSavchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants