-
Notifications
You must be signed in to change notification settings - Fork 1.6k
UBERF-13844,13845: Edit card type UI improvements #10009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
|
Connected to Huly®: UBERF-13849 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements UI improvements for card type editing by adding search functionality to dropdown lists and removing unnecessary confirmation dialogs. The changes enhance user experience by making dropdown selection more efficient and streamlining the enum editing workflow.
- Adds search capability to the DropdownLabelsPopupIntl component with keyboard navigation improvements
- Removes unnecessary confirmation dialog when closing enum editing without changes
- Enables search functionality in the RefEditor dropdown for class selection
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/ui/src/components/DropdownLabelsPopupIntl.svelte | Adds search input, filtering logic, and improved keyboard navigation |
| packages/ui/src/components/DropdownLabelsIntl.svelte | Passes withSearch prop to the popup component |
| plugins/setting-resources/src/components/typeEditors/RefEditor.svelte | Enables search functionality for class selection dropdown |
| plugins/setting-resources/src/components/EditEnum.svelte | Adds logic to skip confirmation dialog when enum values are unchanged |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
ArtyomSavchenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Before:

After:

Related to: https://front.hc.engineering/workbench/platform/tracker/UBERF-13844, https://front.hc.engineering/workbench/platform/tracker/UBERF-13845