Change space card action #10012
Merged
Change space card action #10012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
|
Connected to Huly®: UBERF-13852 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the "move to space" functionality by implementing a transactional approach using ApplyOperations and updates the Move component to use a Card layout instead of a custom dialog.
- Modified
moveToSpacefunction to useApplyOperationsinstead ofTxOperationsfor better transaction handling - Updated Move component to use Card component with improved UI layout and status handling
- Added move action support for card class in the model
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plugins/view-resources/src/utils.ts | Changed moveToSpace function to use ApplyOperations and added space filter to attached documents query |
| plugins/view-resources/src/components/Move.svelte | Refactored to use Card component layout and ApplyOperations with transaction commit |
| plugins/calendar-resources/src/components/ScheduleEditor.svelte | Minor UI update to hide calendar icon in CalendarSelector |
| models/card/src/actions.ts | Added move action template for card class |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ArtyomSavchenko
approved these changes
Oct 3, 2025
aonnikov
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.