Skip to content

Fix guest search security #10021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2025
Merged

Fix guest search security #10021

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f57747
Fix guest search security
BykhovDenis Oct 3, 2025
ecb99ef
Fix formatting
BykhovDenis Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions server/middleware/src/spaceSecurity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,14 +509,17 @@ export class SpaceSecurityMiddleware extends BaseMiddleware implements Middlewar
await this.next?.handleBroadcast(ctx)
}

private getAllAllowedSpaces (account: Account, isData: boolean, showArchived: boolean): Ref<Space>[] {
private getAllAllowedSpaces (
account: Account,
isData: boolean,
showArchived: boolean,
forSearch: boolean = false
): Ref<Space>[] {
const userSpaces = this.allowedSpaces[account.uuid] ?? []
const res = [
...Array.from(userSpaces),
account.uuid as unknown as Ref<Space>,
...this.systemSpaces,
...this.mainSpaces
]
let res = [...Array.from(userSpaces), account.uuid as unknown as Ref<Space>, ...this.mainSpaces]
if (!forSearch || ![AccountRole.Guest, AccountRole.ReadOnlyGuest].includes(account.role)) {
res = [...res, ...this.systemSpaces]
}
const ignorePublicSpaces = isData || account.role === AccountRole.ReadOnlyGuest
const unfilteredRes = ignorePublicSpaces ? res : [...res, ...this.publicSpaces]
if (showArchived) {
Expand Down Expand Up @@ -690,7 +693,7 @@ export class SpaceSecurityMiddleware extends BaseMiddleware implements Middlewar
const newQuery = { ...query }
const account = ctx.contextData.account
if (!isSystem(account, ctx)) {
const allSpaces = this.getAllAllowedSpaces(account, true, false)
const allSpaces = this.getAllAllowedSpaces(account, true, false, true)
if (query.classes !== undefined) {
const res = new Set<Ref<Space>>()
const passedDomains = new Set<string>()
Expand Down
Loading