-
Notifications
You must be signed in to change notification settings - Fork 1.6k
context value dsl #10023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
context value dsl #10023
Conversation
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
|
Connected to Huly®: UBERF-13865 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a DSL (Domain Specific Language) for SelectedContext to replace the JSON-based approach for better performance with nested contexts. The DSL provides a more compact representation that reduces payload size significantly.
- Implements a bi-directional DSL parser and serializer for SelectedContext objects
- Updates context parsing to fallback to DSL when JSON parsing fails
- Refactors ProcessAttribute component to use DSL format by default
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/process/src/dslContext.ts | Core implementation of DSL parser and serializer functions |
| plugins/process/src/utils.ts | Added DSL fallback parsing when JSON fails |
| plugins/process/src/index.ts | Exported DSL context functionality |
| plugins/process/src/tests/dslContext.test.ts | Comprehensive test suite for DSL roundtrip functionality |
| plugins/process/docs/dsl.md | Complete documentation of DSL syntax and usage |
| plugins/process-resources/src/components/ProcessAttribute.svelte | Updated to use DSL format with JSON fallback |
| plugins/process-resources/src/components/attributeEditors/ConfigurePopup.svelte | Enhanced function filtering logic |
| plugins/process-resources/package.json | Added test scripts |
| packages/platform/src/index.ts | Exposed ident module for parsing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
DSL for SelectedContext. As part of preparation for process dsl and for calculating fields separation. Why we need it? Because old way (JSON) was too big, especially for nested context (real example part on screenshot)
