Skip to content

Conversation

@lleokaganov
Copy link
Contributor

Added forced initialization (sending all currently available variables to the callback) on subscription, except for those whose expires will end within the next second — for atomicity.

Implemented smoother error handling and reconnection logic — hopefully, our infamous workspace error is finally gone.

Removed redundant ping when variables are already being sent. Need to remember to check the server behavior for this case.

@huly-github-staging
Copy link

Connected to Huly®: UBERF-13868

@aonnikov aonnikov requested a review from Copilot October 6, 2025 03:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the HulypulseClient with improved subscription initialization, better error handling, and code cleanup. The changes focus on fixing subscription initial state delivery and addressing workspace switching errors through more robust reconnection logic.

  • Added forced initialization for subscriptions to send all current variables to callbacks on subscription
  • Implemented smoother error handling with automatic reconnection instead of throwing errors
  • Cleaned up commented code and improved code consistency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lleokaganov lleokaganov requested a review from Copilot October 7, 2025 08:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@aonnikov aonnikov merged commit dd74587 into develop Oct 7, 2025
15 of 26 checks passed
@aonnikov aonnikov deleted the fix/subscribe-list branch October 7, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants