-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix subscribe initial state, fix switch workspace error, upgrade ping #10026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Connected to Huly®: UBERF-13868 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the HulypulseClient with improved subscription initialization, better error handling, and code cleanup. The changes focus on fixing subscription initial state delivery and addressing workspace switching errors through more robust reconnection logic.
- Added forced initialization for subscriptions to send all current variables to callbacks on subscription
- Implemented smoother error handling with automatic reconnection instead of throwing errors
- Cleaned up commented code and improved code consistency
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Leonid Kaganov <lleo@lleo.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Added forced initialization (sending all currently available variables to the callback) on subscription, except for those whose expires will end within the next second — for atomicity.
Implemented smoother error handling and reconnection logic — hopefully, our infamous workspace error is finally gone.
Removed redundant ping when variables are already being sent. Need to remember to check the server behavior for this case.