Skip to content

Conversation

@aonnikov
Copy link
Member

@aonnikov aonnikov commented Oct 9, 2025

No description provided.

@aonnikov aonnikov requested review from Copilot and lexiv0re October 9, 2025 03:20
@huly-github-staging
Copy link

Connected to Huly®: UBERF-13898

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the manual translation boilerplate for editor placeholders with a new I18nPlaceholderExtension that automatically handles internationalization. The extension manages placeholder translations reactively, subscribing to theme store changes for language updates.

  • Removed manual translation logic from editor components
  • Created a new I18nPlaceholderExtension that extends the TipTap Placeholder extension
  • Updated editor kit to use the new internationalized placeholder extension

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
plugins/text-editor-resources/src/kits/editor-kit.ts Replaced Placeholder import with I18nPlaceholderExtension and updated the kit configuration
plugins/text-editor-resources/src/components/extension/i18nPlaceholder.ts New extension that handles automatic translation of placeholders with theme store subscription
plugins/text-editor-resources/src/components/TextEditor.svelte Removed manual translation logic and updated to use new extension options
plugins/text-editor-resources/src/components/CollaborativeTextEditor.svelte Removed manual translation logic, cleaned up unused imports, and updated placeholder configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@aonnikov aonnikov marked this pull request as draft October 9, 2025 04:21
lexiv0re
lexiv0re previously approved these changes Oct 9, 2025
@aonnikov aonnikov force-pushed the feat-i18n-placeholder branch 2 times, most recently from a55b776 to c921ac8 Compare October 9, 2025 09:43
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
@aonnikov aonnikov force-pushed the feat-i18n-placeholder branch from c921ac8 to b0f818a Compare October 9, 2025 14:21
@aonnikov aonnikov marked this pull request as ready for review October 9, 2025 14:21
@aonnikov aonnikov requested a review from lexiv0re October 9, 2025 14:21
@aonnikov aonnikov merged commit 96c1571 into develop Oct 9, 2025
15 checks passed
@aonnikov aonnikov deleted the feat-i18n-placeholder branch October 9, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants