Prevent duplicating ToDos in documents content #10063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Connected to Huly®: UBERF-13907 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prevents duplicating ToDo items when copying and pasting content within text editor documents by implementing deduplication logic.
- Adds an EditorContextExtension to track the current editor's object context (ID, class, and space)
- Implements a TodoItemPastePlugin that cleans duplicate ToDo attributes during paste operations
- Extends ToDo items with parent context attributes to identify their origin
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| plugins/text-editor-resources/src/kits/editor-kit.ts | Integrates the new EditorContextExtension into the editor kit |
| plugins/text-editor-resources/src/components/extension/todo/todo.ts | Implements deduplication logic and adds parent context tracking to ToDo items |
| plugins/text-editor-resources/src/components/extension/editorContext.ts | Creates new extension to provide editor context for ToDo deduplication |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
plugins/text-editor-resources/src/components/extension/todo/todo.ts
Outdated
Show resolved
Hide resolved
plugins/text-editor-resources/src/components/extension/todo/todo.ts
Outdated
Show resolved
Hide resolved
plugins/text-editor-resources/src/components/extension/todo/todo.ts
Outdated
Show resolved
Hide resolved
n1kolasM
force-pushed
the
separate_todos
branch
from
9b1391b to
05dfd9f
Compare
aonnikov
reviewed
Oct 10, 2025
plugins/text-editor-resources/src/components/extension/todo/todo.ts
Outdated
Show resolved
Hide resolved
aonnikov
previously approved these changes
Oct 10, 2025
Signed-off-by: Nikolay Marchuk <nikolay.marchuk@hardcoreeng.com>
Signed-off-by: Nikolay Marchuk <nikolay.marchuk@hardcoreeng.com>
n1kolasM
force-pushed
the
separate_todos
branch
from
05dfd9f to
e481106
Compare
Signed-off-by: Nikolay Marchuk <nikolay.marchuk@hardcoreeng.com>
Conflicting rules for typescript validation and eslint only work with strange conversion from ParseRule to TagParseRule Signed-off-by: Nikolay Marchuk <nikolay.marchuk@hardcoreeng.com>
aonnikov
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.