Skip to content

Conversation

@GeneralGDA
Copy link
Contributor

This pull request introduces a new abstraction for OS integration and adds support for managing auto-launch settings within the desktop application. It also refactors IPC message handling to use a centralized constants file, improving maintainability and consistency across the codebase. Additionally, new copyright headers are added to several files.

OS Integration & Auto-Launch Feature:

  • Added a new OsIntegration class (desktop/src/main/osIntegration.ts) to encapsulate OS-specific features, including tray management and toggling auto-launch settings.
  • Updated settings logic to support auto-launch: new methods and storage key in Settings, and corresponding unit tests. [1] [2] [3]

IPC Message Refactoring:

  • Created a centralized IpcMessage constants file (desktop/src/ui/ipcMessages.ts) and refactored all IPC message usages in the main and UI processes to use these constants for better consistency and maintainability. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]

Main Process Refactor:

  • Replaced direct usage of TrayController with OsIntegration throughout the main process, including menu actions and badge updates. [1] [2] [3] [4]
  • Added IPC handler for querying auto-launch status.

Copyright and License Headers:

  • Added copyright and license headers to newly created and existing files for legal compliance. [1] [2] [3] [4]

These changes collectively improve the application's extensibility for OS-level features, ensure IPC messaging is robust and maintainable, and establish a foundation for future enhancements.

Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
@GeneralGDA GeneralGDA requested a review from Copilot October 16, 2025 13:57
@huly-github-staging
Copy link

Connected to Huly®: UBERF-13950

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces Windows Desktop auto-launch functionality and improves IPC message handling by centralizing message constants. It creates a new OS integration abstraction to manage platform-specific features like tray management and auto-launch settings, while refactoring all IPC communications to use consistent constants for better maintainability.

Key changes:

  • Added auto-launch feature with OS integration abstraction and settings management
  • Centralized IPC message constants in a dedicated file to replace hardcoded strings
  • Refactored tray controller usage through new OsIntegration class

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
desktop/src/ui/types.ts Added copyright header and auto-launch action/interface definitions
desktop/src/ui/titleBarMenu.ts Updated menu system to support auto-launch toggle with new OS integration
desktop/src/ui/screenShare.ts Added copyright header
desktop/src/ui/preload.ts Refactored to use centralized IPC constants and added auto-launch support
desktop/src/ui/platform.ts Added missing copyright license information
desktop/src/ui/notifications.ts Added copyright header
desktop/src/ui/ipcMessages.ts New file containing centralized IPC message constants
desktop/src/ui/index.ts Added copyright header and updated IPC message usage
desktop/src/main/start.ts Major refactor to use OsIntegration class and centralized IPC constants
desktop/src/main/settings.ts Added auto-launch setting storage and retrieval methods
desktop/src/main/osIntegration.ts New OS integration class encapsulating tray and auto-launch functionality
desktop/src/main/customMenu.ts Updated to use OsIntegration and handle auto-launch menu actions
desktop/src/test/main/settings.test.ts Added unit tests for auto-launch settings functionality

@GeneralGDA GeneralGDA merged commit 3e63a7a into develop Oct 17, 2025
25 of 26 checks passed
@GeneralGDA GeneralGDA deleted the win-desktop-app-launch-on-os-start branch October 17, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants