Skip to content

remove image endpoint from datalake #10112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
Merged

remove image endpoint from datalake #10112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/datalake/pod-datalake/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM hardcoreeng/front-base:v20250916
FROM hardcoreeng/base-slim:v20250916
WORKDIR /app

COPY bundle/bundle.js ./
Expand Down
3 changes: 1 addition & 2 deletions services/datalake/pod-datalake/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"_phase:bundle": "rushx bundle",
"_phase:docker-build": "rushx docker:build",
"_phase:docker-staging": "rushx docker:staging",
"bundle": "node ../../../common/scripts/esbuild.js --keep-names=true --sourcemap=external --external=sharp",
"bundle": "node ../../../common/scripts/esbuild.js --keep-names=true --sourcemap=external",
"docker:build": "../../../common/scripts/docker_build.sh hardcoreeng/datalake",
"docker:tbuild": "docker build -t hardcoreeng/datalake . --platform=linux/amd64 && ../../../common/scripts/docker_tag_push.sh hardcoreeng/datalake",
"docker:abuild": "docker build -t hardcoreeng/datalake . --platform=linux/arm64 && ../../../common/scripts/docker_tag_push.sh hardcoreeng/datalake",
Expand Down Expand Up @@ -72,7 +72,6 @@
"express": "^4.21.2",
"express-fileupload": "^1.5.1",
"postgres": "^3.4.7",
"sharp": "~0.34.3",
"@aws-sdk/client-s3": "^3.738.0",
"@aws-sdk/s3-request-presigner": "^3.738.0",
"@aws-sdk/lib-storage": "^3.738.0",
Expand Down
328 changes: 0 additions & 328 deletions services/datalake/pod-datalake/src/handlers/image.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion services/datalake/pod-datalake/src/handlers/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
//

export * from './blob'
export * from './image'
export * from './meta'
export * from './multipart'
export * from './s3'
5 changes: 0 additions & 5 deletions services/datalake/pod-datalake/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ import {
handleBlobGet,
handleBlobHead,
handleBlobList,
handleImageGet,
handleMetaGet,
handleMetaPut,
handleMetaPatch,
Expand Down Expand Up @@ -262,10 +261,6 @@ export async function createServer (
wrapRequest(ctx, 'multipartUploadAvort', handleMultipartUploadAbort)
)

// Image

app.get('/image/:transform/:workspace/:name', withBlob, wrapRequest(ctx, 'transformImage', handleImageGet)) // no auth

const sendErrorToAnalytics = (err: any): boolean => {
const ignoreMessages = [
'Unexpected end of form', // happens when the client closes the connection before the upload is complete
Expand Down
Loading