-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Drawing board rect, ellipse and line shape drawing. #10142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Stroke width tool visibility fix. Panning cursor position fix. Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
|
Connected to Huly®: UBERF-13983 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces shape drawing tools (line, rectangle, ellipse) to the drawing board, replacing individual tool buttons with a unified tool selection menu. The implementation adds new command types, rendering logic, and preview functionality for shapes while simplifying tool labels across all supported languages.
- Adds three new shape drawing tools with live preview during drawing
- Refactors toolbar UI to use a popup menu for tool selection instead of individual buttons
- Simplifies internationalized tool labels (e.g., "Pen tool" → "Pen")
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/presentation/src/plugin.ts | Adds IntlString declarations for new shape tools |
| packages/presentation/src/drawingCommand.ts | Defines command interfaces for rectangle, ellipse, and straight line |
| packages/presentation/src/drawing.ts | Implements drawing logic, preview rendering, and command storage for shapes |
| packages/presentation/src/components/icons/*.svelte | Adds new icon components and copyright headers |
| packages/presentation/src/components/DrawingBoardToolbar.svelte | Refactors UI to use tool selection popup and removes individual tool buttons |
| packages/presentation/lang/*.json | Updates translations with simplified labels and new shape tool names |
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
0c0f9d7
This pull request refactors the drawing tool selection in the
DrawingBoardToolbarand adds support for new shape tools (line, rectangle, ellipse) to the UI, along with corresponding icons and internationalized labels. The changes improve usability by consolidating tool selection into a popup menu and simplifying tool labels across all supported languages.UI/UX Improvements:
New Features:
shape-line), rectangle (shape-rectangle), and ellipse (shape-ellipse), with corresponding Svelte icon components. [1] [2] [3] [4]Internationalization:
Codebase Maintenance:
Drawing Command Types:
DrawRectCmd,DrawEllipseCmd,DrawStraightLineCmd) indrawing.ts.