Skip to content

Conversation

@GeneralGDA
Copy link
Contributor

This pull request refactors the drawing tool selection in the DrawingBoardToolbar and adds support for new shape tools (line, rectangle, ellipse) to the UI, along with corresponding icons and internationalized labels. The changes improve usability by consolidating tool selection into a popup menu and simplifying tool labels across all supported languages.

UI/UX Improvements:

  • Refactored the toolbar to use a single tool selection button with a popup menu, replacing individual tool buttons for pen, eraser, pan, text, and new shape tools. This makes the interface cleaner and easier to extend with additional tools. [1] [2] [3]
  • Added a visual indicator to the selected tool button and improved the styling for the toolbar popup. [1] [2]

New Features:

  • Introduced new drawing tools: line (shape-line), rectangle (shape-rectangle), and ellipse (shape-ellipse), with corresponding Svelte icon components. [1] [2] [3] [4]

Internationalization:

  • Updated all language JSON files to simplify tool labels (e.g., "Pen" instead of "Pen tool") and added translations for the new shape tools. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

Codebase Maintenance:

  • Added missing copyright/license headers to several icon components. [1] [2] [3] [4] [5] [6]

Drawing Command Types:

  • Extended drawing command imports to include new shape command types (DrawRectCmd, DrawEllipseCmd, DrawStraightLineCmd) in drawing.ts.

Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Stroke width tool visibility fix.
Panning cursor position fix.

Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
@GeneralGDA GeneralGDA requested a review from Copilot October 24, 2025 10:10
@huly-github-staging
Copy link

Connected to Huly®: UBERF-13983

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces shape drawing tools (line, rectangle, ellipse) to the drawing board, replacing individual tool buttons with a unified tool selection menu. The implementation adds new command types, rendering logic, and preview functionality for shapes while simplifying tool labels across all supported languages.

  • Adds three new shape drawing tools with live preview during drawing
  • Refactors toolbar UI to use a popup menu for tool selection instead of individual buttons
  • Simplifies internationalized tool labels (e.g., "Pen tool" → "Pen")

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/presentation/src/plugin.ts Adds IntlString declarations for new shape tools
packages/presentation/src/drawingCommand.ts Defines command interfaces for rectangle, ellipse, and straight line
packages/presentation/src/drawing.ts Implements drawing logic, preview rendering, and command storage for shapes
packages/presentation/src/components/icons/*.svelte Adds new icon components and copyright headers
packages/presentation/src/components/DrawingBoardToolbar.svelte Refactors UI to use tool selection popup and removes individual tool buttons
packages/presentation/lang/*.json Updates translations with simplified labels and new shape tool names

@GeneralGDA GeneralGDA marked this pull request as ready for review October 24, 2025 10:12
aonnikov
aonnikov previously approved these changes Oct 24, 2025
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
@GeneralGDA GeneralGDA dismissed stale reviews from ArtyomSavchenko and aonnikov via 0c0f9d7 October 24, 2025 12:09
@GeneralGDA GeneralGDA merged commit 70a4ea2 into develop Oct 24, 2025
15 checks passed
@GeneralGDA GeneralGDA deleted the drawing-board-rect-shape-drawing branch October 24, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants