Skip to content

Conversation

@aonnikov
Copy link
Member

  1. use socialId cache
  2. do not show typing for unresolved persons
  3. properly reconnect on workspace change
  4. use only one pulse connection

Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
@huly-github-staging
Copy link

Connected to Huly®: UBERF-13984

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses several pulse connection issues by improving the typing indicator functionality and connection management. The changes focus on using cached person data, filtering out unresolved users, and ensuring proper connection lifecycle.

Key changes:

  • Replace social ID lookup with direct person ID resolution using cached data
  • Add filtering to hide typing indicators for unresolved persons
  • Implement workspace-aware reconnection logic and single pulse connection management

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
plugins/communication-resources/src/components/TypingPresenter.svelte Switches from social ID to person ID lookup and filters out unresolved persons
plugins/chunter-resources/src/components/ChannelTypingInfo.svelte Switches from social ID to person ID lookup and filters out unresolved persons
packages/ui/src/components/internal/RootBarExtension.svelte Adds workspace-based keying to force component recreation on workspace change
packages/presentation/src/pulse.ts Refactors connection management to support single connection instance and workspace-aware reconnection

Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
@aonnikov aonnikov merged commit c670690 into develop Oct 24, 2025
15 checks passed
@aonnikov aonnikov deleted the fix-typing branch October 24, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants