Skip to content

Remove redundant tooltip for card type #10145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
Merged

Remove redundant tooltip for card type #10145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/inbox-resources/src/components/InboxCardTitle.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,14 @@
let idTitle: string | undefined
let title: string | undefined

$: navItem.type === 'legacy' &&

Check warning on line 37 in plugins/inbox-resources/src/components/InboxCardTitle.svelte

View workflow job for this annotation

GitHub Actions / formatting 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
doc &&

Check warning on line 38 in plugins/inbox-resources/src/components/InboxCardTitle.svelte

View workflow job for this annotation

GitHub Actions / formatting 

Unexpected nullable object value in conditional. An explicit null check is required
getDocIdentifier(client, doc._id, doc._class, doc).then((res) => {
idTitle = res
})

$: navItem.type === 'legacy' &&

Check warning on line 43 in plugins/inbox-resources/src/components/InboxCardTitle.svelte

View workflow job for this annotation

GitHub Actions / formatting 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
doc &&

Check warning on line 44 in plugins/inbox-resources/src/components/InboxCardTitle.svelte

View workflow job for this annotation

GitHub Actions / formatting 

Unexpected nullable object value in conditional. An explicit null check is required
getDocTitle(client, doc._id, doc._class, doc).then((res) => {
title = res
})
Expand All @@ -54,7 +54,7 @@
<div class="labels">
{#if client.getHierarchy().isDerived(navItem._class, cardPlugin.class.Card)}
{@const label = client.getHierarchy().getClass(doc?._class ?? navItem._class).label}
<span class="title--bold overflow-label clear-mins" use:tooltip={{ label }}>
<span class="title--bold overflow-label clear-mins">
<Label {label} />
</span>
{#if doc}
Expand Down
Loading