Skip to content

Qfix: double approval of review/approve request #10199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2025
+12 −1
Merged

Qfix: double approval of review/approve request #10199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion plugins/controlled-documents-resources/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,11 +443,22 @@ export async function completeRequest (
return
}

await client.update(req, {
const ops = client.apply(req._id)

// Check on the server side if the user has already approved - do not add the second time
// otherwise request is never finished and ends up in a broken state
ops.notMatch(reqClass, {
_id: req._id,
approved: me
})

await ops.update(req, {
$push: {
approved: me
}
})

await ops.commit()
}

export async function saveComment (message: Markup | undefined, req: DocumentRequest): Promise<void> {
Expand Down