Fix bandwidth constraint errors #10211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Savchenko <armisav@gmail.com>
|
Connected to Huly®: UBERF-14075 |
Copilot finished reviewing on behalf of
ArtyomSavchenko
November 14, 2025 10:15
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses bandwidth constraint errors in the LiveKit billing system by handling null bandwidth values. The fix includes both application-level null handling and database schema updates to prevent constraint violations.
- Adds nullish coalescing operator to handle null/undefined bandwidth values in the insert/upsert logic
- Introduces a new migration (migrationV3) to update existing null bandwidth values to 0 and set a DEFAULT constraint
- Modifies the original table creation migration to include DEFAULT 0 for bandwidth
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| services/billing/pod-billing/src/db/postgres.ts | Added null coalescing (?? 0) when inserting bandwidth values to prevent constraint violations |
| services/billing/pod-billing/src/db/migrations.ts | Added migrationV3 to fix existing null values and set DEFAULT constraint; modified migrationV1 to include DEFAULT in initial table creation |
haiodo
approved these changes
Nov 14, 2025
aonnikov
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.