EQMS-1401: track password changed events #10217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
|
Connected to Huly®: UBERF-14084 |
Copilot finished reviewing on behalf of
lexiv0re
November 15, 2025 20:54
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds tracking for password change events by introducing a new PASSWORD_CHANGED event type and recording it whenever a password is set. The implementation includes utility functions to query password change history and a database migration to optimize event queries.
- New
PASSWORD_CHANGEDevent type added toAccountEventTypeenum setPasswordfunction updated to record password change events- Two new query functions:
getLastPasswordChangeEventandisPasswordChangedSince - Database index added for efficient password change event queries
- Comprehensive test coverage for the new query functions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| server/account/src/types.ts | Added PASSWORD_CHANGED event type to the AccountEventType enum |
| server/account/src/utils.ts | Updated setPassword to record events; added getLastPasswordChangeEvent and isPasswordChangedSince utility functions; renamed parameter from personUuid to accountUuid for consistency |
| server/account/src/collections/postgres/migrations.ts | Added v22 migration to create a composite index on account_events table for optimized password change queries |
| server/account/src/tests/utils.test.ts | Added comprehensive test suites for getLastPasswordChangeEvent and isPasswordChangedSince functions |
BykhovDenis
approved these changes
Nov 15, 2025
ArtyomSavchenko
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://front.hc.engineering/workbench/platform/tracker/EQMS-1401