-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Optimise docker build space usage #10224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
|
Connected to Huly®: UBERF-14095 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR optimizes Docker build space usage by switching multiple service Docker images from full base images (hardcoreeng/base and hardcoreeng/front-base) to a slimmer variant (hardcoreeng/base-slim:v20250916), enabling Docker BuildKit, and adding optional cleanup logic for build artifacts. The slim base image uses node:22-slim instead of node:22, reducing image size while maintaining necessary runtime dependencies.
- Migrated 5 services to use the lighter
base-slimDocker image - Added
DOCKER_BUILDKIT: 1across GitHub Actions workflows for improved build performance - Introduced cleanup script logic to remove build artifacts after Docker builds
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
services/payment/pod-payment/Dockerfile |
Changed base image from hardcoreeng/base to hardcoreeng/base-slim:v20250916 |
services/export/pod-export/Dockerfile |
Changed base image from hardcoreeng/base to hardcoreeng/base-slim:v20250916 |
services/billing/pod-billing/Dockerfile |
Changed base image from hardcoreeng/base to hardcoreeng/base-slim:v20250916 |
services/backup/backup-api-pod/Dockerfile |
Changed base image from hardcoreeng/front-base to hardcoreeng/base-slim:v20250916 |
dev/tool/Dockerfile |
Changed base image from unversioned hardcoreeng/base to hardcoreeng/base-slim:v20250916 |
common/scripts/docker_build.sh |
Added cleanup logic for build artifacts (bundle, dist, .rush directories) with bug in flag handling |
.github/workflows/main.yml |
Enabled Docker BuildKit across multiple CI jobs and added cleanup flag to docker-build job |
No description provided.