Fix null error in getReviewers #10229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Savchenko <armisav@gmail.com>
|
Connected to Huly®: UBERF-14133 |
Copilot finished reviewing on behalf of
ArtyomSavchenko
November 19, 2025 05:30
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a null reference error in the getReviewers method by adding defensive null checks for reviewRequests, latestReviews, and their nested properties. The fix prevents crashes when GitHub's API returns unexpected null values in pull request review data.
- Added optional chaining and nullish coalescing operators to safely handle null/undefined values
- Introduced filter steps to remove null entries from arrays before processing
- Added comprehensive test suite with 11 test cases covering various null/undefined scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| services/github/pod-github/src/sync/pullrequests.ts | Added null-safe operators and filters to handle null reviewRequests, latestReviews, and their nested properties |
| services/github/pod-github/src/sync/tests/pullrequests.test.ts | New test file with comprehensive coverage for null/undefined handling scenarios in getReviewers method |
Signed-off-by: Artem Savchenko <armisav@gmail.com>
ArtyomSavchenko
requested review from
BykhovDenis,
GeneralGDA,
aonnikov and
lexiv0re
GeneralGDA
requested changes
Nov 19, 2025
Signed-off-by: Artem Savchenko <armisav@gmail.com>
GeneralGDA
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.