Allow ignore billing #10233
Merged
Allow ignore billing #10233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Connected to Huly®: UBERF-14165 |
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
haiodo
force-pushed
the
allow-ignore-plugins
branch
from
3047aee to
3f3419e
Compare
Copilot finished reviewing on behalf of
ArtyomSavchenko
November 20, 2025 15:06
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables self-hosted environments to disable billing functionality when the BILLING_URL configuration is not specified. The main change conditionally loads billing resources only when BILLING_URL is set, preventing billing UI from appearing in self-hosted deployments that don't need it.
Key Changes:
- Conditional loading of billing resources based on
BILLING_URLconfiguration - Code formatting improvements including import statements and multi-line function calls
- Memory limit increase for a Docker service (from 512m to 1024m)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| dev/prod/src/platform.ts | Adds conditional check to only load billing resources when BILLING_URL is configured; includes formatting improvements for imports and function calls |
| desktop/src/ui/platform.ts | Mirrors the conditional billing resource loading for the desktop platform; includes extensive formatting improvements |
| dev/docker-compose.yaml | Increases memory limit from 512m to 1024m for a service (likely to support development environment needs) |
ArtyomSavchenko
approved these changes
Nov 20, 2025
ArtyomSavchenko
pushed a commit
that referenced
this pull request
Nov 20, 2025
* Disable billing if no billing url is specified Signed-off-by: Andrey Sobolev <haiodo@gmail.com> * Add biling URL check Signed-off-by: Andrey Sobolev <haiodo@gmail.com> --------- Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
ArtyomSavchenko
pushed a commit
that referenced
this pull request
Nov 21, 2025
* Disable billing if no billing url is specified Signed-off-by: Andrey Sobolev <haiodo@gmail.com> * Add biling URL check Signed-off-by: Andrey Sobolev <haiodo@gmail.com> --------- Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If BILLING_URL is not specified, Billing will not be shown to users in self hosted environment.
@ArtyomSavchenko Please take a look, it is first part. Second part will be in huly.core repo and when I will create here.