Fix runtime error in billing #10237
Merged
Fix runtime error in billing #10237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Savchenko <armisav@gmail.com>
ArtyomSavchenko
requested review from
BykhovDenis,
aonnikov,
Copilot and
lexiv0re
|
Connected to Huly®: UBERF-14184 |
Copilot finished reviewing on behalf of
ArtyomSavchenko
November 21, 2025 10:20
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a runtime error that occurs in the billing settings component when the payment URL is not configured. When paymentUrl is null or empty, the groups array is filtered to exclude subscriptions, resulting in an empty array. Accessing groups[0].key on an empty array causes a runtime error.
Key Changes:
- Added optional chaining to safely access
groups[0]?.keyon line 67, preventing crashes when the groups array is empty
GeneralGDA
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.