Pass API key to hello-sign component#19
Merged
dcyriller merged 1 commit intohe9qi:masterfrom Apr 29, 2019
dcyriller:remove-global-config
Merged
Pass API key to hello-sign component#19dcyriller merged 1 commit intohe9qi:masterfrom dcyriller:remove-global-config
dcyriller merged 1 commit intohe9qi:masterfrom
dcyriller:remove-global-config
Conversation
So that you can use different document in different spots of your app.
dcyriller
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the api key being set globally in
config/environment. Instead the API key is given to the component.This will let us to be able to sign different contract in a same app. On one page, you'll be able to provide the component with an API key. On an other one, you'll provide it with a different key.
This PR depends on #13