Conversation
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR reduces the Prometheus plugin’s public surface area by removing exports and eliminating an unused dependency.
Changes:
- Make several helper functions/types non-exported and remove an unused utility function.
- Remove the
use-betweendependency frompackage.json.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| prometheus/src/util.ts | Makes getClusterConfig internal and removes isMetricsEnabled. |
| prometheus/src/request.tsx | Makes Kubernetes response types and createPrometheusEndpoint internal. |
| prometheus/src/components/VisibilityButton/VisibilityButton.tsx | Makes VisibilityButtonProps internal. |
| prometheus/package.json | Removes use-between dependency. |
Files not reviewed (1)
- prometheus/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
illume
requested changes
Apr 25, 2026
Contributor
illume
left a comment
illume
left a comment
There was a problem hiding this comment.
Thanks for these changes.
Can you please address the open review comments?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.