-
Notifications
You must be signed in to change notification settings - Fork 30
Added a GraalVM launcher for HeadlessMc #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is a lot to go through, next time multiple commits, please. |
3arthqu4ke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff, with some nitpicks. I think you can ignore codacy for now, I will clean this up a bit later.
headlessmc-graalvm/src/main/java/me/earth/headlessmc/graalvm/Java11DownloadClient.java
Outdated
Show resolved
Hide resolved
...lessmc-graalvm/src/test/java/me/earth/headlessmc/java/download/Java11DownloadClientTest.java
Show resolved
Hide resolved
...lessmc-graalvm/src/test/java/me/earth/headlessmc/java/download/Java11DownloadClientTest.java
Show resolved
Hide resolved
headlessmc-java/src/main/java/me/earth/headlessmc/java/download/ArchiveExtractor.java
Show resolved
Hide resolved
headlessmc-launcher-wrapper/src/main/java/me/earth/headlessmc/wrapper/Main.java
Outdated
Show resolved
Hide resolved
headlessmc-jline/src/main/java/me/earth/headlessmc/jline/JlineProgressbarProvider.java
Show resolved
Hide resolved
headlessmc-launcher/src/main/java/me/earth/headlessmc/launcher/command/LaunchCommand.java
Show resolved
Hide resolved
headlessmc-graalvm/src/main/java/me/earth/headlessmc/graalvm/Main.java
Outdated
Show resolved
Hide resolved
|
And lots of failed tests? |
3arthqu4ke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, will improve some of the code, add 1-2 features and release soon.
|
Codacy seems to have a problem and can be ignored for now. |
Added a GraalVM launcher for HeadlessMc