Add failing specs for scope and relative url

[LTe]

When I use in application

ENV['RAILS_RELATIVE_URL_ROOT'] = 'my_app'

and in my routes

scope :my_app do
  devise_for :users
end

devise double render relative part of URL. I am including a test that does not pass.

test_returns_to_the_default_redirect_location_considering_the_relative_url_root_and_scope(FailureTest) [/home/lite/work/devise/test/failure_app_test.rb:67]: <"http://test.host/scoped/scoped_admin/sign_in"> expected but was <"http://test.host/scoped/scoped/scoped_admins/sign_in">.

[josevalim]

Thanks for the pull request but I don't understand how the test is supposed to pass. You are setting a route scoped to "scoped" and then relative_url_options to "/scoped", so they must appear duplicated in the generated path. If you have Devise scoped to "/admin" and your application relative url set to "/foo/bar", you want the final route to be "/foo/bar/admin/". I don't see why it should not appear duplicated given they are the same.

What am I missing?

[LTe]

When I set relative_url_options to /foo/bar I need to put all my routes inside:

scope 'foo/bar' do
  # routes
end

When I define devise inside foo/bar

scope 'foo/bar' do
  devise_for :users
end

then devise will generate #{relative_url_options}/#{scope}/#{users} so /foo/bar/foo/bar/users. Of course I can execute devise_for :users outside scope block. It looks a bit inconsistent. Should I always execute devise_for outside scope method?

[josevalim]

When I set relative_url_options to /foo/bar I need to put all my routes inside scoped

That is not supposed to be true. Setting the relative_url_options is supposed to be transparent and it should not require changes in your router. If it requires, it is a bug in Rails.