2204 regression with db authenticatable#2205
Merged
josevalim merged 2 commits intoJan 9, 2013
Merged
Conversation
For a point release upgrade, Devise should not throw an exception when trying to downcase or strip globally configured keys. This would be a breaking change in functionality and this test demonstrates the issue.
This avoids calling strip and downcase on globally configured keys that may not exist on all devise models. Fixes heartcombo#2204, a regression introduced by PR heartcombo#2135. Also included a note about the intentional use of respond_to.
Contributor
|
❤️ 💚 💙 💛 💜 |
josevalim
pushed a commit
that referenced
this pull request
Jan 9, 2013
…nticatable 2204 regression with db authenticatable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes Issue #2204 which is a regression introduced in PR #2135. Devise should not fail due to unchanged configuration when upgrading a point release, at least not without some kind of warning or wiki explanation.