Revert "Removes reloading of routes when eager loading ..."#3241
Merged
Conversation
lucasmazza
added a commit
that referenced
this pull request
Oct 3, 2014
Revert "Removes reloading of routes when eager loading ..."
Contributor
|
❤️ 💚 💙 💛 💜 |
|
Consequently routes are loaded twice at Rails startup, which is not good for Rails startup time if there are many routes. Any other ideas how to avoid this? |
sidonath
added a commit
to sidonath/devise
that referenced
this pull request
Apr 21, 2016
As has been seen in a previous pull request, some applications require routes to be loaded before the code is eagerly loaded, which implies that all Rails applications using Devise need to have routes reloaded twice: heartcombo#3241 This can incur a very significant slowdown for large apps that have a lot of routes or a lot of controllers, so reloading should be optional.
sidonath
added a commit
to sidonath/devise
that referenced
this pull request
Apr 21, 2016
As has been seen in a previous pull request, some applications require routes to be loaded before the code is eagerly loaded, which implies that all Rails applications using Devise need to have routes reloaded twice: heartcombo#3241 This can incur a very significant slowdown for large apps that have a lot of routes or a lot of controllers, so reloading should be optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #3195, that proved to be create an regression @ #3153 (comment). We need to eager load the routes to ensure that the our mappings and helpers are defined before loading the rest of the app.