Refactor the devise_error_messages! helper to render a partial#4616
Merged
tegon merged 1 commit intoheartcombo:masterfrom Dec 18, 2018
prograhamer:refactor-error-view-to-template
Merged
Refactor the devise_error_messages! helper to render a partial#4616tegon merged 1 commit intoheartcombo:masterfrom prograhamer:refactor-error-view-to-template
tegon merged 1 commit intoheartcombo:masterfrom
prograhamer:refactor-error-view-to-template
Conversation
This should make it more intuitive and easier for developers using the project to implement their own layout for errors.
Member
|
It seems ok to me. @rafaelfranca Do you have any concerns about this? |
afomera
pushed a commit
to afomera/devise-bootstrapped
that referenced
this pull request
Feb 15, 2019
* Update readme with Bootstrap 4 information * Revised bundler gem to version greater than 1.12 * Render partial instead of devise_error_messages! This will remove the deprecation warning from DeviseHelper#devise_error_messages message as from Devise 4.6.0 in favor of rendering partials. Ref: #5, heartcombo/devise#4616, and platformatec/devise@76b87dc0e83736cf16e3ffbc465fcd8ee3c06d46 * Add email_changed.html.erb * Bump version * Fixed Travis error
ionut998
added a commit
to ionut998/activeadmin
that referenced
this pull request
Mar 1, 2019
From version 4.6 Devise deprecated the use of `devise_error_messages!` helper method in favour of rendering a the `error_messages` partial. [Devise PR](heartcombo/devise#4616) that introduced this. Warning message that get's solved with this PR ``` DEPRECATION WARNING: [Devise] `DeviseHelper.devise_error_messages!` is deprecated and it will be removed in the next major version. To customize the errors styles please run `rails g devise:views` and modify the `devise/shared/error_messages` partial. ``` resolves activeadmin#5688
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make it more intuitive and easier for developers using the project to implement their own layout for errors.