refactor method name to be more consistent#5055
Merged
feliperenan merged 1 commit intoheartcombo:masterfrom Apr 5, 2019
saiqulhaq:master
Merged
refactor method name to be more consistent#5055feliperenan merged 1 commit intoheartcombo:masterfrom saiqulhaq:master
feliperenan merged 1 commit intoheartcombo:masterfrom
saiqulhaq:master
Conversation
feliperenan
reviewed
Apr 3, 2019
|
|
||
| def rails_5_and_down? | ||
| return false if rails_5_up? | ||
| def rails_4_to_50? |
Collaborator
There was a problem hiding this comment.
Wdyt of among_rails_4_and_5?
Contributor
Author
There was a problem hiding this comment.
I removed this method
because current Devise doesn't support rails 3
so I think no need to check is it rails 4 or 3
feliperenan
approved these changes
Apr 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix 1aab449