Move build to GitHub Actions#5338
Merged
Merged
Conversation
Keep only the lock for the main Gemfile to keep Devise consistent with the other heartcombo libs.
Bundler 1.x uses git instead of https by default and we don't have that github source setting in the Gemfile, but this should work.
ruby-head was always in allowed failures with travis anyway, and we never really paid much attention to it, so let's just remove it entirely for now.
The build is breaking with 2.x (which is expected), so this is a step to get it to green on GA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to lock devise on OmniAuth 1.0 for now otherwise some of the tests would 💥 due to a hard check we have. I'm updating it to allow 2.0 on #5327, I'll catch up that branch once this gets merged.