Skip to content

Conversation

@ryanoasis
Copy link
Contributor

This should fix "Generated comment block doesn't follow whitespace settings (tabs vs. spaces) #11"

Also added these flags (and you can see the example effects below):

/**
 * g:jsdoc_access_descriptions = 1
 * g:jsdoc_underscore_private = 1
 */

/**
 * my function
 *
 * @public
 * @param {number} x x coor
 * @param {number} y y coor
 * @return {undefined}
 */
function myFunction(x, y) {
}

/**
 * my function 2
 *
 * @private
 * @param {number} x x coor
 * @param {number} y y coor
 * @return {undefined}
 */
function _myFunction2(x, y) {
}

/**
 * g:jsdoc_access_descriptions = 2
 * g:jsdoc_underscore_private = 1
 */

/**
 * my function
 *
 * @access public
 * @param {number} x x coor
 * @param {number} y y coor
 * @return {undefined}
 */
function myFunction(x, y) {
}

/**
 * my function 2
 *
 * @access private
 * @param {number} x x coor
 * @param {number} y y coor
 * @return {undefined}
 */
function _myFunction2(x, y) {
}


/**
 * g:jsdoc_access_descriptions = 2
 * g:jsdoc_underscore_private = 0
 */

/**
 * my function
 *
 * @access public
 * @param {number} x x coor
 * @param {number} y y coor
 * @return {undefined}
 */
function myFunction(x, y) {
}

/**
 * my function 2
 *
 * @access public
 * @param {number} x x coor
 * @param {number} y y coor
 * @return {undefined}
 */
function _myFunction2(x, y) {
}

/**
 * g:jsdoc_access_descriptions = 0
 * g:jsdoc_underscore_private = 0
 */


/**
 * my function
 *
 * @param {number} x x coor
 * @param {number} y y coor
 * @return {undefined}
 */
function myFunction(x, y) {
}

/**
 * my function 2
 *
 * @param {number} x x coor
 * @param {number} y y coor
 * @return {undefined}
 */
function _myFunction2(x, y) {
}

…ttings (tabs vs. spaces)) and adds access tags (with underscore private convention)
@heavenshell
Copy link
Owner

Thx. I'll look it later.

@heavenshell heavenshell merged commit 7c48ec4 into heavenshell:master Jan 15, 2015
@heavenshell
Copy link
Owner

@ryanoasis Sorry for late late response.
LGTM, but there is a problem.

if l:autoexpandtab == 'noexpandtab'

this code did not work.
&l:expandtab returns 0 or 1.
so, I fix and merged.

Anyway, thanks for your contribution.

@ryanoasis
Copy link
Contributor Author

@heavenshell Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants