Skip to content

Conversation

@faceleg
Copy link
Contributor

@faceleg faceleg commented Jul 7, 2013

No description provided.

@heavenshell
Copy link
Owner

Thanks for pull request.

I've got an error.

Error detected while processing /tmp/vim-jsdoc/ftplugin/javascript/jsdoc.vim:
line   15:
E121: Undefined variable: g:jsdoc_default_mapping
E15: Invalid expression: !hasmapto('<Plug>(jsdoc)') && g:jsdoc_default_mapping

I did not set g:jsdoc_default_mapping in my .vimrc.
IMO initializing g:jsdoc_default_mapping should be do in ftplugin/javascript/jsdoc.vim.
What do you think?

If error solved, it's ok to merge.

@faceleg
Copy link
Contributor Author

faceleg commented Jul 7, 2013

My fault, you're right - I've fixed it.

@heavenshell heavenshell merged commit 0e1f3a2 into heavenshell:master Jul 8, 2013
@heavenshell
Copy link
Owner

@faceleg Merged your PR.
Thank you for making jsdoc.vim better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants