tooling: hapi-resurrect-session + auto-migrate chain-forward#36
Open
heavygee wants to merge 2 commits into
Open
tooling: hapi-resurrect-session + auto-migrate chain-forward#36heavygee wants to merge 2 commits into
heavygee wants to merge 2 commits into
Conversation
Operator hand-built this 361-line script on 2026-06-06 to recover a HAPI session whose `cursorSessionId` was set to NULL when the hub auto-archived on agent crash. The procedure (path-hash discovery against ~/.cursor/chats/<md5(path)>/, sqlite metadata patch, hapi-restart-hub, POST /api/sessions/<id>/resume) was used twice in the same session and works; committing before it gets clobbered by a `git clean` the way the attach scripts did last week. Why this matters for the ACP migration (PR #34 / upstream tiann#824): the migrator refuses sessions in `lifecycleState='running'` and is not designed to recover crashed sessions with `cursorSessionId=NULL`. A crashed legacy session has to be resurrected (back to `lifecycleState='inactive'` with `cursorSessionProtocol='stream-json'`) BEFORE `hapi cursor migrate <id>` becomes applicable. This script closes that gap. Surface: hapi-resurrect-session <hapi-session-id-or-prefix> [--cursor-uuid <uuid>] # skip auto-discovery [--symlink-old-path <old> --as <new>] # moved worktrees [--name '<friendly label>'] [--dry-run] [--no-restart-hub] Exit codes: 0 ok, 1 discovery failed, 2 sqlite patch failed, 3 resume call failed, 4 cursor-agent crashed within 8s of spawn. No new dependencies (Python 3 stdlib + sqlite3 + curl). Co-authored-by: Cursor <cursoragent@cursor.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
4 tasks
After successful resurrection the session is back to inactive + cursorSessionProtocol=stream-json by design (legacy launcher knows how to dispatch the stream-json store). Once #34's invisible auto- migrate ships, SyncEngine.resumeSession will transplant this to ACP transparently on the operator's next Reopen — no manual migrate command required. This adds three terminal-stdout lines at the end of the script so the operator sees the next step without having to remember #34 exists: [hapi-resurrect-session] session is on legacy stream-json. [hapi-resurrect-session] next: open this session in the HAPI web UI and click Reopen. [hapi-resurrect-session] once #34 (tiann#824) auto-migrate is live, that [hapi-resurrect-session] Reopen will transparently transplant this session to ACP [hapi-resurrect-session] (cp store.db, verify session/load, flip protocol; ~15-20s banner). [hapi-resurrect-session] kill-switch: HAPI_CURSOR_LEGACY_AUTO_MIGRATE=0 in hub env. If LIVE_PROTO is already 'acp' (e.g. operator re-ran resurrect on a session that auto-migrate had already handled), the script just prints "session is already on ACP. No further action needed." instead. Pure UX polish. No code-path change. Replaces the earlier attach-agent-chat.ts post-attach hint that I dropped — that approach was obsoleted by #34 moving migration from operator-driven CLI to invisible auto-fire inside resumeSession. Co-authored-by: Cursor <cursoragent@cursor.com>
heavygee
force-pushed
the
tooling/legacy-chat-acp-alignment
branch
from
c143c0e to
228757c
Compare
heavygee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Force-pushed 2026-06-08 to drop the obsolete post-attach hint commit. PR #34 evolved between 2026-06-06 and 2026-06-08 from "operator-driven CLI/button migrator" to "invisible auto-migrate inside
SyncEngine.resumeSession". The post-attach hint's reference tohapi cursor migrate <id>was already wrong by the time #34 settled, so dropping it is the honest fix.Two-commit branch now:
tooling(resurrect)(2ed1bb30) — commitsscripts/tooling/hapi-resurrect-session.sh(361 lines, operator-authored 2026-06-06). Recovers HAPI sessions auto-archived on agent crash withcursorSessionId=NULL(the failure mode wherePOST /api/sessions/:id/resumereturns 500 "Resume session ID unavailable").tooling(resurrect) chain-forward(228757ce) — adds 18 lines of stdout polish at the end of the script that points the operator atReopen→ auto-migrate (feat(cursor): operator-driven legacy stream-json -> ACP session migrator (transplant) #34) as the next step. Pure UX polish; no code-path change.Why this matters relative to #34
#34's
maybeAutoMigrateLegacyCursorSessionfires insideSyncEngine.resumeSession. ButresumeSessionnever reaches the auto-migrate call if it errors out at thecursorSessionIdlookup first. A crashed-archived session withcursorSessionId=NULLis permanently stranded as un-resumable — auto-migrate has nothing to migrate because there's no resume token to look up the legacy store with.hapi-resurrect-session.shfixes the null first (path-hash discovery against~/.cursor/chats/<md5(metadata.path)>/, sqlite metadata patch, hub restart,POST /resume). After this script succeeds, the session is back tolifecycleState=inactivewithcursorSessionProtocol=stream-json. The operator clicks Reopen → #34's auto-migrate fires transparently → session ends up on ACP.The chain is: resurrect → Reopen → auto-migrate. The polish commit's stdout lines literally walk the operator through that chain so they don't have to remember step 3 exists.
End-to-end flow (crash branch, after #34 lands)
Refusal contract for
hapi-resurrect-session.sh/api/sessions/<id>/resumereturned non-2xxIdempotent: re-running on an already-resurrected session is safe.
--dry-runprints the discovery + planned patch without writing.Why this stays as a script (not a hub endpoint)
cursorSessionId=NULLrecovery (verified viagh search issues --repo tiann/hapi).POST /api/sessions/:id/resurrectendpoint, or better, as prevention: capturecursorSessionIdto a session-events log BEFORE archive so the token is never lost in the first place. Either of those is a separate upstream issue/PR.Test plan
bash -n scripts/tooling/hapi-resurrect-session.shsyntax-checks--helpprints the documented usage blockCompanion branch
tooling/backfill-truncation-warnings(#37) — raises backfillMAX_MESSAGEScap from 2000 to 50_000 and surfaces aBACKFILL TRUNCATEDwarning when transcripts exceed the cap. Independent of migration concerns; should land on its own merits.