Skip to content

[create:vocabularies] Add missing arguments to empty method call. Resolves #3271.#3342

Merged
jmolivas merged 1 commit into
hechoendrupal:masterfrom
brayfe:master
Jun 10, 2017
Merged

[create:vocabularies] Add missing arguments to empty method call. Resolves #3271.#3342
jmolivas merged 1 commit into
hechoendrupal:masterfrom
brayfe:master

Conversation

@brayfe
Copy link
Copy Markdown
Contributor

@brayfe brayfe commented Jun 9, 2017

When using drupal console to create Vocabularies or Terms, the creation of the "description" field was missing an argument in the getRandom()->sentences() call. This caused the following error:

ArgumentCountError: Too few arguments to function Drupal\Component\Utility\Random::sentences(),
0 passed in /vendor/drupal/console/src/Utils/Create/TermData.php on line 69 and at least 1 
expected in Drupal\Component\Utility\Random->sentences() (line 192 of 
/core/lib/Drupal/Component/Utility/Random.php).

Solution was to supply the value provided by the user ($nameWords) to the function.
Test using:
drupal create:vocabularies --limit=5 --name-words=5 or
drupal create:terms --limit=5 --name-words=5 and selecting a vocab to use.

@jmolivas jmolivas added this to the RC-22 milestone Jun 10, 2017
@jmolivas jmolivas merged commit dcf768c into hechoendrupal:master Jun 10, 2017
@jmolivas
Copy link
Copy Markdown
Member

@brayfe Thanks for your contribution, your PR was merged. This will be included on the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants