Collection routes are provided by core#3344
Merged
Merged
Conversation
pfrenssen
commented
Jun 12, 2017
| if ($collection_route = $this->getCollectionRoute($entity_type)) { | ||
| $collection->add("entity.{$entity_type_id}.collection", $collection_route); | ||
| } | ||
| // Provide your custom entity routes here. |
Contributor
Author
There was a problem hiding this comment.
For config entities the HtmlRouteProvider has now become unnecessary. I have replaced the logic with this comment that explains that custom routes can be added here.
Shall we keep this dev hint or would it be better to just remove the file?
Contributor
Author
|
The test failed because it was cancelled for some reason. When it is restarted it will probably turn green again :) |
Member
|
@pfrenssen Thanks for your contribution, your PR was merged. This will be included on the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating an entity we were providing the collection route in the
HtmlRouteProviderbut this is no longer necessary since core now provides the route. This was added in Drupal 8.2.0 in Issue #2767853 by tstoeckler: Provide a route for collections of entities.