Skip to content

#663 Generated entity links should point to paths, not routes#702

Merged
jmolivas merged 2 commits intohechoendrupal:masterfrom
heilop:663-generated-entity-links-should-point-to-paths
Jul 2, 2015
Merged

#663 Generated entity links should point to paths, not routes#702
jmolivas merged 2 commits intohechoendrupal:masterfrom
heilop:663-generated-entity-links-should-point-to-paths

Conversation

@heilop
Copy link
Copy Markdown
Contributor

@heilop heilop commented Jun 17, 2015

I changed point to paths.

@jmolivas jmolivas modified the milestone: 0.7.15-release Jun 20, 2015
@webflo
Copy link
Copy Markdown
Contributor

webflo commented Jun 25, 2015

@heilop Prefix /node is wrong. Please use the same url patterns as in https://github.com/hechoendrupal/DrupalConsole/blob/master/templates/module/routing-entity-content.yml.twig

@heilop
Copy link
Copy Markdown
Contributor Author

heilop commented Jun 25, 2015

Thanks @webflo, I will change that.

jmolivas added a commit that referenced this pull request Jul 2, 2015
…-point-to-paths

#663 Generated entity links should point to paths, not routes
@jmolivas jmolivas merged commit 53b7119 into hechoendrupal:master Jul 2, 2015
@jmolivas
Copy link
Copy Markdown
Member

jmolivas commented Jul 2, 2015

Thanks for the PR @heilop

Thanks for reviewing it @webflo

@heilop
Copy link
Copy Markdown
Contributor Author

heilop commented Jul 2, 2015

Thanks for help me @jmolivas
Thanks @webflo for the code review
yay!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants