Remove deprecated default_value key from entity_value#724
Merged
jmolivas merged 1 commit intohechoendrupal:masterfrom Jul 2, 2015
Merged
Remove deprecated default_value key from entity_value#724jmolivas merged 1 commit intohechoendrupal:masterfrom
jmolivas merged 1 commit intohechoendrupal:masterfrom
Conversation
…etDefaultValue() as example.
jmolivas
added a commit
that referenced
this pull request
Jul 2, 2015
Remove deprecated default_value key from entity_value
Member
|
Thanks for the PR @artfulrobot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The correct way to set a default value on an entity is to use
setDefaultValue()and not to pass adefault_valuekey in the base table defs.See related patch to examples module.
Nb. I think it is useful to keep this code (which sets a zero-length string as the default) in there as an example of how to provide a default.