Wrong handling of Entity::save() return value#803
Merged
jmolivas merged 1 commit intohechoendrupal:masterfrom Aug 23, 2015
Merged
Wrong handling of Entity::save() return value#803jmolivas merged 1 commit intohechoendrupal:masterfrom
jmolivas merged 1 commit intohechoendrupal:masterfrom
Conversation
Contributor
Author
|
Here is the relevant documentation from |
7e7daea to
4fca663
Compare
pfrenssen
added a commit
to pfrenssen/DrupalConsole
that referenced
this pull request
Aug 20, 2015
…boolean but a constant indicating whether it is a new or existing entity.
…boolean but a constant indicating whether it is a new or existing entity.
4fca663 to
f117123
Compare
Member
|
@pfrenssen: Thanks for the PR |
jmolivas
added a commit
that referenced
this pull request
Aug 23, 2015
Wrong handling of Entity::save() return value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the entity form code that is generated thinks that the return value of
Entity::save()is a boolean indicating success or failure, but this is not correct. This probably changed at some point in the past.In current HEAD if a failure occurs during the saving of the entity an exception is thrown. Instead of a boolean, this method returns either
SAVED_NEWorSAVED_UPDATED. We can use this information to provide a more fitting message.