Fallback to embedded font when system font is unsupported#74
Merged
Conversation
|
I just ran into this issue trying to run the examples, found this PR, switched to this branch and recompiled. Still getting a panic. |
Member
Author
|
@safijari Thanks for testing it! Could you share a backtrace? |
|
When I run |
Member
Author
|
Hey @safijari, thanks for reporting back. Your issue is not related to font loading. It seems My advice is to check that your Vulkan drivers are installed correctly. I am also working on a renderer alternative that should be able to fallback to software mode in this cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69.
This PR embeds Lato in
iced_wgpuand uses it when the default system fonts cannot be handled byrusttype. This is a dirty fix and should increase binary size a bit. It's meant to be a workaround while we move the text pipeline iniced_wgputo something that offers more support (see #33).Additionally, the PR also removes the loading of a monospace font, reducing memory footprint. We can use the default font instead for the debug/overlay view.