Removed the custom browserFilesAlias and Claude reviews#740
Merged
Conversation
|
Claude code review could not run. The request to the Claude API failed (possible causes: billing limit reached, token expired, or service unavailable). Review this PR manually. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the browser build configuration for hed-validator by removing the custom esbuild alias plugin and relying on the package browser field for redirecting Node-specific file utilities when bundling for browsers.
Changes:
- Added a
browserfield mapping inpackage.jsonto redirect./src/utils/files.jsto./src/utils/files.browser.js(and keptfs: false). - Removed the custom
browserFilesAliasesbuild plugin and adjusted the browser-build comment accordingly. - Removed two GitHub Actions workflows related to “Claude” automation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Adds browser field mapping for browser-safe file utilities resolution. |
| esbuild.mjs | Removes the custom alias plugin and relies on package.json browser mapping for the browser bundle. |
| .github/workflows/claude.yaml | Removes the Claude Code workflow. |
| .github/workflows/claude-code-review.yml | Removes the Claude Code Review workflow. |
|
Claude code review could not run. The request to the Claude API failed (possible causes: billing limit reached, token expired, or service unavailable). Review this PR manually. |
VisLab
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.